Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #881: NavigatorLanguage::language does not need to be nullable #885

Closed
wants to merge 1 commit into from
Closed

Fix #881: NavigatorLanguage::language does not need to be nullable #885

wants to merge 1 commit into from

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Mar 15, 2016

Hi guys,

Please check this small fix for #881

Thanks

zcorpan pushed a commit that referenced this pull request Mar 16, 2016
@yuyokk @zcorpan
Fix #881: Make NavigatorLanguage#language non-nullable
d5ccd65 
PR: #885
@zcorpan
Copy link
Member

zcorpan commented Mar 16, 2016

Thanks, merged as d5ccd65

@zcorpan zcorpan closed this Mar 16, 2016
@yuyokk yuyokk deleted the no-nullable branch March 16, 2016 15:56
@domenic domenic added the clarification Standard could be clearer label Mar 16, 2016
domenic added a commit that referenced this pull request May 27, 2016
@domenic
Handle reentrant custom element definition
2be0af3 
Fixes #1329, by disallowing reentrant element definition from defining
something with a name or constructor that is currently being defined.

Also properly wraps the script-executing steps in a "prepare to run
script"/"clean up after running script" pair, as part of #885.
@domenic domenic mentioned this pull request May 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clarification Standard could be clearer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyokk @zcorpan @domenic